Repository navigation
ci: pin the MSRV job back to Rust 1.91 - #63
Conversation
Dependabot's github-actions group (ac088c3) moved dtolnay/rust-toolchain@1.91.0 to @1.120.0. That action takes the toolchain from its ref, so the AMR minimum-Rust job asked rustup for a nonexistent Rust 1.120.0 and has failed on every main commit since. The declared minimum (tinyvoice, tinyvoice-module rust-version) is 1.91.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): ci: pin the MSRV job back to Rust 1.91. The change pins the MSRV job back to `dtolnay/rust-toolchain@1.91.0` in `.github/workflows/ci.yml` and adds a dependabot ignore entry for the `dtolnay/rust-toolchain` dependency in `.github/dependabot.yml` so its tags are not treated as action releases. Review snapshot
Completeness: Complete What changedThe change reverts the MSRV job's toolchain pin in `.github/workflows/ci.yml` from `dtolnay/rust-toolchain@1.120.0` back to `@1.91.0`, matching the declared minimum Rust version, and adds an ignore entry for the `dtolnay/rust-toolchain` dependency in `.github/dependabot.yml` so its Rust-version tags are never treated as action releases for upgrade. No permissions are widened, both action refs remain pinned to specific tags, and no untrusted context is interpolated into a shell. Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Summary
AMR minimum Rust (1.91)has failed on every main commit since dependabot's ac088c3 ("ci: bump the github-actions group"). That commit moveddtolnay/rust-toolchain@1.91.0to@1.120.0. The action takes the toolchain from its ref, so the job asks rustup for Rust 1.120.0, which doesn't exist ("could not download nonexistent rust version1.120.0-x86_64-unknown-linux-gnu"), and fails in about 7s before any build. Main is red at f8fbdbc, 7000fc3 and 26c72d5, and the same check fails on #61..github/workflows/ci.yml:19: back todtolnay/rust-toolchain@1.91.0, the declared minimum (rust-version = "1.91"for tinyvoice and tinyvoice-module)..github/dependabot.yml: ignoredtolnay/rust-toolchainin the github-actions group. Its tags are Rust versions, not action releases, so it must never be "upgraded".Test plan
AMR minimum Rust (1.91)green.