Skip to content

chore(deny): ignore RUSTSEC-2026-0387 until the k256 chain is upgraded - #122

Closed
M3gA-Mind wants to merge 2 commits into
tinyhumansai:mainfrom
M3gA-Mind:chore/deny-ignore-rustsec-2026-0387
Closed

M3gA-Mind wants to merge 2 commits into
tinyhumansai:mainfrom
M3gA-Mind:chore/deny-ignore-rustsec-2026-0387

Conversation

@M3gA-Mind

Copy link
Copy Markdown
Contributor

Summary

Adds RUSTSEC-2026-0387 to deny.toml's [advisories] ignore list, with a comment and a reason, so module-ci / supply-chain passes again on main.

Problem

  • RUSTSEC-2026-0387 (crypto-bigint: multiple timing-variability issues in operations meant to be constant-time) was published after main 921987c's last green supply-chain run (2026-10-23). cargo deny check advisories now fails on every PR, including chore(deps): bump tinybus 0.3.6, tinytools 0.6.0, tinystoragedrivers 2.1.1 #121 (the tinybus 0.3.6 bump).
  • Path: crypto-bigint 0.5.5 <- elliptic-curve 0.13.8 <- k256 0.13.4 (also via ecdsa 0.16.9) <- coins-bip32 / coins-bip39 0.13.2 <- tinywallet.
  • The fix is crypto-bigint >=0.7.6, which only the semver-major k256 0.14 / coins-bip3x line brings. cargo update -p crypto-bigint cannot reach it.

Solution

  • One ignore entry with an explanatory comment and a reason (cargo-deny's { id, reason } form). It was accepted temporarily by user decision on 2026-10-26, so the tinybus 0.3.6 module releases can proceed.
  • I make no claim about whether tinywallet's use of these operations is exposed. The entry only records that the fix is not reachable without the major upgrade.

Follow-up

crypto-bigint 0.5.5 (timing side-channel) is reached via elliptic-curve
0.13.8 <- k256 0.13.4 <- coins-bip32 / coins-bip39 0.13.2. The fix needs
crypto-bigint >=0.7.6, which only the semver-major k256 0.14 /
coins-bip3x line brings, so cargo update cannot reach it. Accepted
temporarily (user decision 2026-10-26) so the tinybus 0.3.6 releases can
proceed; remove the entry when the k256 chain is upgraded.
@tinysweeper

tinysweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Reviewed head: b7d98e3ab4880936992d27fb62f01e7291c2c9a4

Verdict: Ready for maintainer review · Priority: none
Coverage: Reviewed 1 of 1 files.
Pull request purpose (title): chore(deny): ignore…

Diagnostics and supporting details

Full summary

Pull request purpose (title): chore(deny): ignore RUSTSEC-2026-0387 until the k256 chain is upgraded. Tiny Sweeper completed its review; deterministic results follow.

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: Test coverage is assessed from changed tests and lane evidence; execution is not claimed without trusted check data.

What changed

Only `deny.toml` changes: the empty `ignore = []` under `[advisories]` becomes a list holding one inline table with `id = "RUSTSEC-2026-0387"` and a `reason`, plus a comment describing the crypto-bigint 0.5.5 / k256 0.13.4 / coins-bip3x exposure, the required semver-major fix, and the condition for removing the entry. Licenses, bans, sources, and all code paths are unchanged.

Features

  • Modified — Advisory ignore entry for RUSTSEC-2026-0387: Suppresses the cargo-deny advisory failure for RUSTSEC-2026-0387 so the supply-chain check passes on main and existing PRs. The suppression is scoped to a single advisory id and documented with a reason and removal plan, but the comment's stated version chain (coins-bip32/coins-bip39 0.13.2) may not match the repository's pinned coins-bip3x versions. (deny.toml, deny.toml all-features = true)

Tests

  • configuration — Change is limited to deny.toml, a cargo-deny configuration file; no Rust code or runtime behavior is altered.: No test execution is claimed. (deny.toml)

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: The added ignore entry is structured as `cargo-deny` expects and follows the file's own instruction to add entries only with an explanatory comment and plan.
  • Lane summary: The change adds one advisory ignore to deny.toml with a detailed reason comment, matching the file's own instruction to add entries only with an explanation. I could not verify the advisory identifier or the transitive version chain against a live advisory database, but nothing in the diff contradicts the surrounding policy. One detail worth confirming: the reason comment claims coins-bip32/coins-bip39 0.13.2, whereas the repository's Cargo.toml pins coins-bip32 0.17 and coins-bip39 0.17, so the version chain in the comment may not match what actually resolves. _The code index is behind this pull request (indexed at `433c412d243d`), so retrieved context may be out of date._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: The ignore is narrowly scoped to one advisory id, is a denial-policy relaxation rather than a code path, and carries a documented reason and removal plan.
  • Lane summary: This adds an advisory ignore for RUSTSEC-2026-0387 (crypto-bigint 0.5.5 via k256 0.13) with a documented reason and removal plan, matching the file's own instruction to add entries only with a comment explaining the exposure and the plan. The change is a denial-policy relaxation, not a code path; no attacker-controlled input or new sink is involved, and no repository rule is broken. No findings. _The code index is behind this pull request (indexed at `433c412d243d`), so retrieved context may be out of date._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: Commits lane answered with no sensitive content found in committed files.
  • Lane summary: No sensitive content in committed files. _The code index is behind this pull request (indexed at `433c412d243d`), so retrieved context may be out of date._

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: The diff adds a single deny.toml advisory ignore entry with a comment and reason, matching the description's statement of the solution and follow-up.
  • Lane summary: The diff adds a single deny.toml advisory ignore entry with a comment and reason, which matches the description exactly; the description is accurate and complete for this change. There are no reportable defects. _The code index is behind this pull request (indexed at `433c412d243d`), so retrieved context may be out of date._
Evidence and run details
  • Models: ladder/vectors-oai3, deepseek-v4.1-flash
  • Spend: $0.000060
  • Tokens: 40111 input · 1092 output · 10752 cached · 75 embedding
  • Updated: 2026-10-26T09:42:13Z
Head State Pass summary
e30c17c7e7ad ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-26T08:20:41Z)
b7d98e3ab488 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-26T09:42:13Z)

tinysweeper 0.1.2

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 16dc9354-10f4-44e5-a394-59f86b960b7a
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

Diagnostics

Total spend: $0.0001

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 26, 2026
@M3gA-Mind M3gA-Mind closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant