Room 1 - volcano script added#14
Open
tlestang wants to merge 1 commit into
Open
Conversation
| "#3aefaf", "#0b57dd", "#f666b7", "#cf1833", "#a35c0a", | ||
| "#bc0bfe", "#61ff41", "#eabf72", "#09dbc3", "#ffffff") | ||
|
|
||
| do_map = function(vulc_type, colid = NULL) { |
There was a problem hiding this comment.
This should be defined before this script, not in the middle of it
| mutate(logpop10 = log10(population_within_10_km+0.1)) %>% | ||
| select(primary_volcano_type, pop=logpop10, longitude, latitude) | ||
|
|
||
| # cleaning data a bit as there are some plural versions of volcano names |
There was a problem hiding this comment.
I would put this in a seperate function
vvleech
reviewed
Feb 10, 2022
| "#3aefaf", "#0b57dd", "#f666b7", "#cf1833", "#a35c0a", | ||
| "#bc0bfe", "#61ff41", "#eabf72", "#09dbc3", "#ffffff") | ||
|
|
||
| do_map = function(vulc_type, colid = NULL) { |
There was a problem hiding this comment.
Would be good to have a brief comment explaining what this function does
YijieYin
reviewed
Feb 10, 2022
| sc_max <- max(processed_volcano$pop) | ||
| sc_min <- min(processed_volcano$pop) | ||
|
|
||
| col_palette = c("#d11141", "#00b159", "#00aedb", "#f37735", "#ffc425", |
There was a problem hiding this comment.
Perhaps better to use an existing colour palette. Indexing col_palette in this case doesn't work if colid > 15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.