Room 1 - apply_vaccine_py#7
Open
tlestang wants to merge 1 commit into
Open
Conversation
YijieYin
reviewed
Feb 10, 2022
| inject_first_jab(ind) | ||
| ndoses = ndoses - 1 | ||
| else: | ||
| raise OutOfDosesException |
There was a problem hiding this comment.
I'm not sure what 'raise' does. How is it different from 'print'?
Owner
Author
There was a problem hiding this comment.
Using raise allows me to do stuff like
try:
# something
except OutOfDosesException:
# do something else
| inject_second_jab(ind) | ||
| else: | ||
| inject_first_jab(ind) | ||
| ndoses = ndoses - 1 |
There was a problem hiding this comment.
this line should be indented as now ndoses gets reduced by 1 regardless of what happens in the if
tlestang
commented
Feb 10, 2022
| def apply_vaccine_to_population(population, ndoses, threshold_age): | ||
| for ind in population: | ||
| if ndoses > 0: | ||
| if (ind["age"] > threshold_age or ind["isAtRisk"]): |
Owner
Author
There was a problem hiding this comment.
if (isEligible(ind)):
# then do something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.