[PROD] - Jan 26 v1 by kkartunov · Pull Request #25 · topcoder-platform/autopilot-v6

kkartunov · 2026-01-13T08:34:24Z

https://topcoder.atlassian.net/browse/PS-495

…ng sent

…mplete.

github-actions · 2026-01-13T08:34:39Z

        state: 'END',
        operator: AutopilotOperator.SYSTEM,
        projectStatus: challenge.status,
+        skipReviewCompletionCheck: true,


[❗❗ correctness]
The addition of skipReviewCompletionCheck: true could potentially bypass important review completion checks. Ensure that this change is intentional and that all necessary conditions are met before skipping these checks. Consider documenting the rationale for this change to avoid confusion in future maintenance.

github-actions · 2026-01-13T08:34:43Z

    expect(financeApiService.generateChallengePayments).toHaveBeenCalledWith(
      challenge.id,
    );
+    expect(kafkaService.produce).toHaveBeenCalledWith(


[💡 maintainability]
The produce method of kafkaService is being called with a payload that includes the topic key, which seems redundant since the topic is already specified as the first argument. Consider removing the topic key from the payload to avoid redundancy and potential confusion.

github-actions · 2026-01-13T08:34:48Z

+        payload,
+      };
+
+      await this.kafkaService.produce(KAFKA_TOPICS.CHALLENGE_UPDATED, message);


[⚠️ reliability]
Consider adding a retry mechanism for the Kafka message production in case of transient failures. This can improve the reliability of the message delivery.

github-actions · 2026-01-13T08:34:48Z

+        `Published challenge update for completed challenge ${challengeId}.`,
+      );
+    } catch (error) {
+      const err = error as Error;


[⚠️ correctness]
The catch block logs the error but does not rethrow it or handle it in a way that would allow the caller to know that the operation failed. Consider whether the caller should be informed of this failure to take appropriate action.

github-actions · 2026-01-13T08:34:53Z

+      : null;
+
+    if (
+      this.isAppealsPhaseName(updatedPhase.name) &&


[⚠️ correctness]
The condition previousScheduledStart !== updatedScheduledStart is used to determine if successor phases should be rescheduled. Consider if there are scenarios where the scheduled start date might change but not require rescheduling, or vice versa. Ensure this logic aligns with business requirements.

github-actions · 2026-01-13T08:34:53Z

    };

-    const scheduledJobId = await this.schedulePhaseTransition(nextPhaseData);
+    const scheduledJobId = await this.reschedulePhaseTransition(


[⚠️ design]
The method reschedulePhaseTransition is used here, replacing schedulePhaseTransition. Ensure that this change is intentional and that reschedulePhaseTransition handles all necessary logic for both scheduling and rescheduling phases.

+    "source": "FinanceApiService",
+    "details": {
+      "url": "https://api.topcoder-dev.com/v6/finance/challenges/8a8423ed-62cc-4760-bc81-34a0c1a6b27a",
+      "token": "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6Ik5VSkZORGd4UlRVME5EWTBOVVkzTlRkR05qTXlRamxETmpOQk5UYzVRVUV3UlRFeU56TTJRUSJ9.eyJpc3MiOiJodHRwczovL3RvcGNvZGVyLWRldi5hdXRoMC5jb20vIiwic3ViIjoib1VNc2VNbmM1UlhtZVVYSUU1VEZhVmpKQThhWjE3bGNAY2xpZW50cyIsImF1ZCI6Imh0dHBzOi8vbTJtLnRvcGNvZGVyLWRldi5jb20vIiwiaWF0IjoxNzY3NTA2MjY3LCJleHAiOjE3Njc1OTI2NjcsInNjb3BlIjoiYWxsOmNoYWxsZW5nZXMgcmVhZDpjaGFsbGVuZ2VzIHdyaXRlOmNoYWxsZW5nZXMgdXBkYXRlOnJldmlld19zdW1tYXRpb24gcmVhZDpyZXZpZXdfc3VtbWF0aW9uIGRlbGV0ZTpyZXZpZXdfc3VtbWF0aW9uIGNyZWF0ZTpyZXZpZXdfc3VtbWF0aW9uIGFsbDpyZXZpZXdfc3VtbWF0aW9uIHJlYWQ6YnVzX3RvcGljcyB3cml0ZTpidXNfYXBpIHJlYWQ6cmVzb3VyY2VzIHdyaXRlOnJlc291cmNlcyBkZWxldGU6cmVzb3VyY2VzIHVwZGF0ZTpyZXNvdXJjZXMgYWxsOnJlc291cmNlcyBjcmVhdGU6Y2hhbGxlbmdlcyBjcmVhdGU6cmVzb3VyY2VzIHVwZGF0ZTpjaGFsbGVuZ2VzIGNyZWF0ZTpwYXltZW50cyBjcmVhdGU6cmV2aWV3X29wcG9ydHVuaXR5IHJlYWQ6cmV2aWV3X29wcG9ydHVuaXR5IHVwZGF0ZTpyZXZpZXdfb3Bwb3J0dW5pdHkgYWxsOnJldmlld19vcHBvcnR1bml0eSIsImd0eSI6ImNsaWVudC1jcmVkZW50aWFscyIsImF6cCI6Im9VTXNlTW5jNVJYbWVVWElFNVRGYVZqSkE4YVoxN2xjIn0.fnPQHubMhoRtBcV9IIvWG1bdvvumiFxZLwwUAFNEVVOhhbpFJ4x4XmA9rvjqX1B7ElR_000wyJTj338v5tajop518gDLKKCP8hOVQnlIDu2zxzd598yNeKmW4HpFdpj_mApgrWW3FU8UaLPP4-qA-N5XnYUg6LI_zPtxXDusuzx7cu0e991_vG2azwExmQR0lk_k7z6CRFo0Q4Ntg_trna3ggsGcT-o8dblRHiKiF0WYGW8tG3LMM7jXHoF2MRO59edHSvSafpd4-87tW1I2HsPcG0cH8YYrWSiRSvRlLKbO8HyAmAQ2-FMNSVH_hFuSmyTNPqCqxFUHKTfQBFvfnw",


+    "source": "FinanceApiService",
+    "details": {
+      "url": "https://api.topcoder-dev.com/v6/finance/challenges/8a8423ed-62cc-4760-bc81-34a0c1a6b27a",
+      "token": "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6Ik5VSkZORGd4UlRVME5EWTBOVVkzTlRkR05qTXlRamxETmpOQk5UYzVRVUV3UlRFeU56TTJRUSJ9.eyJpc3MiOiJodHRwczovL3RvcGNvZGVyLWRldi5hdXRoMC5jb20vIiwic3ViIjoib1VNc2VNbmM1UlhtZVVYSUU1VEZhVmpKQThhWjE3bGNAY2xpZW50cyIsImF1ZCI6Imh0dHBzOi8vbTJtLnRvcGNvZGVyLWRldi5jb20vIiwiaWF0IjoxNzY3NTA2MjY3LCJleHAiOjE3Njc1OTI2NjcsInNjb3BlIjoiYWxsOmNoYWxsZW5nZXMgcmVhZDpjaGFsbGVuZ2VzIHdyaXRlOmNoYWxsZW5nZXMgdXBkYXRlOnJldmlld19zdW1tYXRpb24gcmVhZDpyZXZpZXdfc3VtbWF0aW9uIGRlbGV0ZTpyZXZpZXdfc3VtbWF0aW9uIGNyZWF0ZTpyZXZpZXdfc3VtbWF0aW9uIGFsbDpyZXZpZXdfc3VtbWF0aW9uIHJlYWQ6YnVzX3RvcGljcyB3cml0ZTpidXNfYXBpIHJlYWQ6cmVzb3VyY2VzIHdyaXRlOnJlc291cmNlcyBkZWxldGU6cmVzb3VyY2VzIHVwZGF0ZTpyZXNvdXJjZXMgYWxsOnJlc291cmNlcyBjcmVhdGU6Y2hhbGxlbmdlcyBjcmVhdGU6cmVzb3VyY2VzIHVwZGF0ZTpjaGFsbGVuZ2VzIGNyZWF0ZTpwYXltZW50cyBjcmVhdGU6cmV2aWV3X29wcG9ydHVuaXR5IHJlYWQ6cmV2aWV3X29wcG9ydHVuaXR5IHVwZGF0ZTpyZXZpZXdfb3Bwb3J0dW5pdHkgYWxsOnJldmlld19vcHBvcnR1bml0eSIsImd0eSI6ImNsaWVudC1jcmVkZW50aWFscyIsImF6cCI6Im9VTXNlTW5jNVJYbWVVWElFNVRGYVZqSkE4YVoxN2xjIn0.fnPQHubMhoRtBcV9IIvWG1bdvvumiFxZLwwUAFNEVVOhhbpFJ4x4XmA9rvjqX1B7ElR_000wyJTj338v5tajop518gDLKKCP8hOVQnlIDu2zxzd598yNeKmW4HpFdpj_mApgrWW3FU8UaLPP4-qA-N5XnYUg6LI_zPtxXDusuzx7cu0e991_vG2azwExmQR0lk_k7z6CRFo0Q4Ntg_trna3ggsGcT-o8dblRHiKiF0WYGW8tG3LMM7jXHoF2MRO59edHSvSafpd4-87tW1I2HsPcG0cH8YYrWSiRSvRlLKbO8HyAmAQ2-FMNSVH_hFuSmyTNPqCqxFUHKTfQBFvfnw",


github-actions · 2026-01-13T08:34:58Z

+      },
+    );
+
+    challengeApiService.advancePhase.mockImplementation(


[⚠️ maintainability]
The advancePhase mock implementation is quite complex and could be simplified by using a data-driven approach or extracting the logic into a helper function. This would improve maintainability and readability.

github-actions · 2026-01-13T08:34:58Z

+      },
+    );
+
+    await scheduler.advancePhase(payload);


[⚠️ correctness]
Consider adding assertions to verify the state of reviewPhase and appealsPhase after the advancePhase calls. This would ensure that the phases are correctly updated and improve the test's robustness.

github-actions · 2026-01-13T08:35:06Z

  ): void {
    this.phaseChainCallback = callback;
+    Logger.log(
+      `[PHASE CHAIN] Phase chain callback registered (pid ${process.pid}).`,


[💡 maintainability]
Consider using this.logger instead of Logger.log for consistency with other logging statements in the class.

github-actions · 2026-01-13T08:35:06Z

-            await this.reviewService.getCompletedReviewCountForPhase(
-              data.phaseId,
-            );
+          if (!data.skipReviewCompletionCheck) {


[⚠️ correctness]
The addition of the skipReviewCompletionCheck flag introduces a conditional path that could lead to skipping necessary review completion checks. Ensure that this flag is used appropriately and that its implications are well understood.

github-actions · 2026-01-13T08:35:06Z

@@ -879,7 +885,6 @@ export class SchedulerService implements OnModuleInit, OnModuleDestroy {
              (phase) =>


[❗❗ correctness]
The removal of the !phase.actualStartDate condition may lead to phases being opened that should not be. Verify that this change aligns with the intended logic for opening appeals-related phases.

github-actions · 2026-01-13T08:35:06Z

                data.challengeId,
                data.projectId,
-                data.projectStatus,
+                data.projectStatus ?? ChallengeStatusEnum.ACTIVE,


[💡 design]
The use of the nullish coalescing operator (??) to default data.projectStatus to ChallengeStatusEnum.ACTIVE is a good practice. Ensure that ChallengeStatusEnum.ACTIVE is the appropriate default status in all contexts where this is applied.

github-actions · 2026-01-13T08:35:06Z

+      return;
+    }
+
+    const context = await this.resolveProjectContext(data);


[⚠️ reliability]
Ensure that the resolveProjectContext method handles all potential error cases, especially when interacting with external services like challengeApiService. Consider adding more robust error handling or retries if necessary.

github-actions · 2026-01-13T08:35:13Z

              },
            });
+
+            if (updateResult.count === 0) {


[⚠️ maintainability]
The updateResult.count === 0 check is used to determine if the phase was updated, but it might be more robust to handle this scenario explicitly with a specific error or log message to ensure clarity on why the transaction is returning early.

github-actions · 2026-01-13T08:35:13Z

              },
            });
+
+            if (updateResult.count === 0) {


[⚠️ maintainability]
The updateResult.count === 0 check is used again here. Consider adding a specific log message or error handling to clarify why the transaction is returning early, similar to the previous block.

github-actions · 2026-01-13T08:35:13Z

+                  durationSeconds > 0 &&
+                  desiredStartSource
+                ) {
+                  const desiredStartDate = new Date(desiredStartSource);


[⚠️ correctness]
The conversion of desiredStartSource to a Date object without validation could lead to unexpected behavior if desiredStartSource is not a valid date string. Consider adding validation to ensure desiredStartSource is a valid date before conversion.

github-actions · 2026-01-13T08:35:13Z

+    if (!dateA || !dateB) {
+      return false;
+    }
+    return new Date(dateA).getTime() === new Date(dateB).getTime();


[⚠️ correctness]
The datesAreSame method converts both dates to Date objects and compares their time values. Ensure that the input dates are valid to prevent potential runtime errors.

github-actions · 2026-01-13T08:35:16Z

  prizeSets: IChallengePrizeSet[];
  terms: any[];
-  skills: any[];
+  skills: { id: string }[];


[⚠️ correctness]
Changing the type of skills from any[] to { id: string }[] improves type safety by specifying the expected structure of skill objects. However, ensure that all parts of the codebase interacting with skills are updated to handle this new structure to prevent runtime errors.

jmgasper added 6 commits January 7, 2026 12:54

Better handling of end-of-challenge event raising

4fde7a1

Fix for processing phases too quickly leading to duplicate emails bei…

bac88fd

…ng sent

Better end of review handling (PM-2991)

e4b3216

Debug logging for review-->appeals transition issue

f78b1bb

Runtime error fix

6478847

Updates to work on review closing immediately when all reviews are co…

6ca82a3

…mplete.

kkartunov requested a review from jmgasper January 13, 2026 08:34

github-actions Bot reviewed Jan 13, 2026

View reviewed changes

github-advanced-security AI found potential problems Jan 13, 2026

View reviewed changes

github-actions Bot reviewed Jan 13, 2026

View reviewed changes

kkartunov merged commit 5301542 into master Jan 13, 2026
8 of 9 checks passed

		@@ -879,7 +885,6 @@ export class SchedulerService implements OnModuleInit, OnModuleDestroy {
		(phase) =>

Conversation

kkartunov commented Jan 13, 2026

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Check warning

Check warning

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants