Conversation
…ir schedule. This would include: Registration, Submission, Checkpoint Submission, Appeals. This should NOT include phases that only close when all deliverables have been received, including: Screening, Review, Approval, Iterative Review, Checkpoint Screening, Checkpoint Review. 2. For Standard Review / Screening phase opened, we are running into issues with this flow: * Review phase opens * Pending reviews are created * Submission phase is REOPENED * New submissions come in * Extended submission phase closes * Review phase reopens and creates pending reviews for the new submissions that came in What happens is that we end up with pending reviews for submissions now that shouldn't have reviews because the submitter submitted an update during the extended submission phase. We need to handle this case to ensure that any pending reviews that no longer should apply because they are associated with submissions that are no longer the latest submission, should be deleted. This would apply to: Checkpoint Screening, Checkpoint Review, Screening, and Review phases. 3. For the identified duplicate / race hotspots, let's make sure these are handled appropriately and have safeguards in place so that duplicate reviews aren't created and that only reviews for the latest submission from members (unless the challenge allows multiple submissions) are supported 4. Removed SchedulerService.ensureTopgearPostMortemReview since that's not a feature we need to support
…nto f2f-ai-screening
…e get aiworkflowcompelted
What was broken Public reviewer openings created from First2Finish iterative review configs could be created as regular review opportunities. When an application was approved, review-api assigned the member the Reviewer resource role, so the review app showed no iterative-review submissions for that reviewer. Root cause Autopilot defaulted missing reviewer opportunity types to REGULAR_REVIEW. Manual and legacy F2F reviewer configs can omit the explicit type even when they are attached to the Iterative Review phase. What was changed Autopilot now resolves the review opportunity type from the linked reviewer phase before falling back to REGULAR_REVIEW. Iterative Review phase reviewers without an explicit type now create ITERATIVE_REVIEW opportunities, which keeps approved members aligned with the Iterative Reviewer role. Added a regression test for the missing-type F2F iterative review path. Any added/updated tests Added PhaseScheduleManager coverage to assert that a reviewer on the Iterative Review phase with no explicit type creates an ITERATIVE_REVIEW opportunity.
What was broken Public reviewer openings created from First2Finish iterative review configs could be created as regular review opportunities. When an application was approved, review-api assigned the member the Reviewer resource role, so the review app showed no iterative-review submissions for that reviewer. Root cause Autopilot defaulted missing reviewer opportunity types to REGULAR_REVIEW. Manual and legacy F2F reviewer configs can omit the explicit type even when they are attached to the Iterative Review phase. What was changed Autopilot now resolves the review opportunity type from the linked reviewer phase before falling back to REGULAR_REVIEW. Iterative Review phase reviewers without an explicit type now create ITERATIVE_REVIEW opportunities, which keeps approved members aligned with the Iterative Reviewer role. Added a regression test for the missing-type F2F iterative review path. Any added/updated tests Added PhaseScheduleManager coverage to assert that a reviewer on the Iterative Review phase with no explicit type creates an ITERATIVE_REVIEW opportunity.
PM-4691: infer iterative opportunity type from F2F review phase
PM-4691: infer iterative opportunity type from F2F review phase
…nto f2f-ai-screening
PM-4368 F2F ai screening
…to fix-phase-advance-check
Fix phase advance check
…nto PM-4868_prevent-review-deletion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.