Conversation
What was broken The earlier member-api fix corrected Marathon Match rerate eligibility, but autopilot's challenge status-update path only triggered finance and point sync when it observed a challenge becoming COMPLETED. Challenges completed outside ChallengeCompletionService could miss the member-api challenge-level rerate call. Root cause The automatic rerate hook was added to ChallengeCompletionService, while PhaseScheduleManager's completed-status reconciliation path was left with only payment and point side effects. What was changed PhaseScheduleManager now calls memberApiService.rerateChallengeSubmitterRatings once when an update transitions a challenge to COMPLETED, including the path where overdue phase processing refreshes the challenge into COMPLETED. Member-api still decides whether the challenge is rated and which native or named rating dimensions apply. Any added/updated tests Updated PhaseScheduleManager unit coverage to assert the completed-status update path triggers submitter rerating once, skips non-completed statuses, and rerates when immediate phase closures complete the challenge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The earlier member-api fix corrected Marathon Match rerate eligibility, but autopilot's challenge status-update path only triggered finance and point sync when it observed a challenge becoming COMPLETED. Challenges completed outside ChallengeCompletionService could miss the member-api challenge-level rerate call.
Root cause
The automatic rerate hook was added to ChallengeCompletionService, while PhaseScheduleManager's completed-status reconciliation path was left with only payment and point side effects.
What was changed
PhaseScheduleManager now calls memberApiService.rerateChallengeSubmitterRatings once when an update transitions a challenge to COMPLETED, including the path where overdue phase processing refreshes the challenge into COMPLETED. Member-api still decides whether the challenge is rated and which native or named rating dimensions apply.
Any added/updated tests
Updated PhaseScheduleManager unit coverage to assert the completed-status update path triggers submitter rerating once, skips non-completed statuses, and rerates when immediate phase closures complete the challenge.
Validation: