When advancing AI phase, count the pending workflows for latest submissions only#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the logic for counting in-progress AI workflow runs in the
ReviewServiceto consider only the latest submissions per user or submission, ensuring more accurate metrics. It also adds comprehensive tests to verify the new behavior and improves logging details for better observability.Improvements to AI workflow run counting:
getInProgressAiWorkflowRunCountto use a Common Table Expression (latest_submissions) that selects only the latest submission for each user or submission, ensuring that only in-progress workflow runs for these are counted.Testing enhancements:
review.service.spec.tsto verify thatgetInProgressAiWorkflowRunCountcorrectly counts only in-progress AI workflow runs for the latest submissions and checks the generated SQL for expected clauses.Logging improvements:
getInProgressAiWorkflowRunCountto include alatestSubmissionsOnly: trueflag in the log details, making it clear that only the latest submissions are considered.