[HOTFIX] Update pending workflows counting for latest submissions#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the logic for counting in-progress AI workflow runs by ensuring that only the latest submissions per participant are considered. This improves the accuracy of workflow run metrics and ensures that outdated or superseded submissions do not affect the count. Additionally, the changes include thorough unit tests to validate the new logic and improved logging for better traceability.
Enhancements to in-progress AI workflow run counting:
ReviewService.getInProgressAiWorkflowRunCountto use a common table expression (WITH latest_submissions AS (...)) that selects only the latest submission per participant, ensuring that the count reflects only the most recent submissions.latestSubmissionsOnly: true, indicating that only the latest submissions are considered in the count.Testing improvements:
review.service.spec.tsto verify thatgetInProgressAiWorkflowRunCountaccurately counts only in-progress AI workflow runs for the latest submissions and checks that the generated SQL query contains the expected logic.