Conversation
…-ai-only PM-5203 approval phase ai only
…-submitters PM-5226 - hide score for submitters
…er-platform/review-api-v6 into allow-to-edit-scores
Allow to edit scores
What was broken Marathon Match scorer validation could not create a downloadable test submission before launch because Review API uploads either followed normal submission lifecycle checks or went to DMZ storage. Root cause The ECS scorer downloads clean submissions, while manual upload creates normal submissions through DMZ, phase, submitter, counter, scan, and notification side effects that are not appropriate for pre-launch validation. What was changed Added an admin/M2M validation-upload endpoint that stores the uploaded file directly in clean submission storage and creates an active file submission row without normal lifecycle side effects. Any added/updated tests Added unit tests for clean validation submission creation and missing-file rejection.
Consider timeout as terminal status, when fetching latest runs, move nulls to end
PM-5231: Add clean validation submission upload
Prevent downloading all artifacts
…into hide-final-score
Hide final score
Fix visibility for reviewer and MM for submissionId and score
Fixes for score visibility in MMs and challenges
Return run details
Sync master into dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.