Skip to content

[PROD HOTFIX] Allow cancelled events to be persisted to db even for dump workflow step #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 1 commit into from
Jun 12, 2026
Merged

[PROD HOTFIX] Allow cancelled events to be persisted to db even for dump workflow step #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/shared/modules/global/workflow-queue.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,6 @@ export class WorkflowQueueHandler {

const aiWorkflowRuns = await this.prisma.aiWorkflowRun.findMany({
where: {
status: { in: ['DISPATCHED', 'IN_PROGRESS'] },
gitRunId: `${event.workflow_job.run_id}`,
},
include: {
Expand All @@ -520,7 +519,7 @@ export class WorkflowQueueHandler {

if (aiWorkflowRuns.length > 1) {
this.logger.error(
`ERROR! There are more than 1 workflow runs in DISPATCHED status and workflow.gitWorkflowId=${event.workflow_job.name}!`,
`ERROR! There are more than 1 workflow runs for workflow=${event.workflow_job.name} and gitWorkflowId=${event.workflow_job.run_id}!`,
);
Comment on lines 521 to 523
return;
}
Expand All @@ -530,14 +529,19 @@ export class WorkflowQueueHandler {

if (
aiWorkflowRun &&
!['DISPATCHED', 'IN_PROGRESS'].includes(aiWorkflowRun.status)
!['INIT', 'DISPATCHED', 'IN_PROGRESS'].includes(aiWorkflowRun.status)
) {
const errorMessage = `Unexpected aiWorkflowRun status '${aiWorkflowRun.status}' for gitRunId=${event.workflow_job.run_id} and workflowJobName=${event.workflow_job.name}`;
this.logger.error(errorMessage);
return;
}

if (event.workflow_job.name === 'dump-workflow-context') {
const conclusion = event.workflow_job.conclusion?.toUpperCase();
const terminalStatus = this.normalizeWorkflowConclusion(conclusion);
if (
event.workflow_job.name === 'dump-workflow-context' &&
terminalStatus !== 'CANCELLED'
) {
Comment on lines +539 to +544
this.logger.log(
`Ignoring dump-workflow-context job event for run ${event.workflow_job.run_id}`,
);
Expand All @@ -555,7 +559,6 @@ export class WorkflowQueueHandler {
return;
}

const conclusion = event.workflow_job.conclusion?.toUpperCase();
switch (event.action) {
case 'in_progress':
if (aiWorkflowRun.status !== 'DISPATCHED') {
Expand All @@ -579,7 +582,6 @@ export class WorkflowQueueHandler {
});
break;
case 'completed': {
const terminalStatus = this.normalizeWorkflowConclusion(conclusion);
const didRetry =
['FAILURE', 'TIMEOUT'].includes(terminalStatus) &&
(await this.retryWorkflowRunIfEligible(
Expand Down
Loading