Skip to content

Lua 5.3 integer support#11

Open
lukealonso wants to merge 1 commit into
torch:masterfrom
lukealonso:integer
Open

Lua 5.3 integer support#11
lukealonso wants to merge 1 commit into
torch:masterfrom
lukealonso:integer

Conversation

@lukealonso
Copy link
Copy Markdown

No description provided.

Comment thread types.lua
end,

read = function(arg, idx)
return string.format("arg%d = (%s)lua_tointeger(L, %d);", arg.i, typename, idx)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this break Lua 5.2 and Lua 5.1 support, as they do not have lua_tointeger. Can we guard it with a version check somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants