Traffic signs: picker, map overlay, and multi-country catalog#13
Draft
tordans wants to merge 2 commits into
Draft
Traffic signs: picker, map overlay, and multi-country catalog#13tordans wants to merge 2 commits into
tordans wants to merge 2 commits into
Conversation
Introduce a prep script using @osm-traffic-signs/converter that emits TrafficSignIndex.json and TrafficSigns.xcassets for Germany. The POI editor shows a + control on traffic_sign tags when the map country has a catalog, opening a searchable grid picker with chip selection and compose/decompose preserving unrecognized fragments. Display settings gain a Show Traffic Signs toggle that draws sign chains on nodes and ways with directional tag handling. Co-authored-by: Tobias <t@tobiasjordans.de>
Bump @osm-traffic-signs/converter to 0.5.1 and rebuild the bundled index and asset catalog for DE, BE, AT, CA, PL, FR, AU, and BR (~1990 SVGs). Fix the Node build script to import converter data modules directly, avoiding the package main entry that loads SVG loaders Node cannot resolve. Add named-value entries (city_limit, maxspeed, stop, etc.) to each country catalog, overlay refresh on map data changes, and improved way directional rendering. Picker shows a signpost fallback icon for named values. Co-authored-by: Tobias <t@tobiasjordans.de>
cursor
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds traffic sign support to Go Map!! using the published
@osm-traffic-signs/converterpackage (v0.5.1).src/traffic-signs/): npm script generatesTrafficSignIndex.jsonandTrafficSigns.xcassetsfrom the converter; wired intosrc/update_all.sh.+button ontraffic_sign,traffic_sign:forward, andtraffic_sign:backwardwhen the current map region has a bundled catalog.Catalog scope (v0.5.1)
Bundled catalogs for 8 countries: DE, BE, AT, CA, PL, FR, AU, BR (~1990 SVG imagesets).
Country selection follows the existing map region (
currentRegion.country). The picker and overlay are hidden when no catalog exists for the active country.Each catalog includes synthetic named-value entries (
city_limit,maxspeed,stop,give_way, etc.) for values without dedicated SVGs; these show a signpost SF Symbol in the picker and a text placeholder on the map.Testing
src/traffic-signs/update.sh(orsrc/update_all.sh) after bumping the converter version.traffic_sign=DE:310;city_limit— picker shows chips, map overlay shows icons.+appears and catalog search returns local signs.+button, overlay hidden.traffic_sign:forward+ generictraffic_sign— generic fills backward direction without duplicating forward.Notes
TrafficSigns.xcassetswhen the converter adds countries or signs..svgimports from the package main entry.