Skip to content

⚡ Bolt: Replace O(n) array filtering with O(log n) binary search in time-series lookups - #85

Draft
toreleon wants to merge 2 commits into
masterfrom
bolt-optimize-array-filter-18229871251248953845
Draft

⚡ Bolt: Replace O(n) array filtering with O(log n) binary search in time-series lookups#85
toreleon wants to merge 2 commits into
masterfrom
bolt-optimize-array-filter-18229871251248953845

Conversation

@toreleon

Copy link
Copy Markdown
Owner

💡 What: Replaces the O(n) .filter() array scanning with an O(log n) findLastBarIndex() binary search utility for time-series lookups in backtestRunner.ts and dnsePublic.ts.
🎯 Why: During backtesting, the runtime needs to repeatedly fetch the price of a ticker "as of" the simulated time. Previously, this was done using .filter((b) => b.time <= asOf) which created a new array and checked every single element. Since time-series data is already sorted chronologically, this created an unnecessary bottleneck of $O(T \times N)$ operations where $T$ is the number of intervals and $N$ is the number of historical price bars.
📊 Impact: Reduces algorithmic complexity of historical time lookups from $O(n)$ to $O(\log n)$. For a dataset of 1,000 bars, this requires at most ~10 checks instead of exactly 1,000 element scans plus array allocations per simulation step per stock ticker.
🔬 Measurement: Verified using existing test suite (pnpm test) to ensure lookups yield exact same output. Type integrity verified via pnpm typecheck.


PR created automatically by Jules for task 18229871251248953845 started by @toreleon

Replaces the O(n) `.filter()` array scanning with an O(log n) `findLastBarIndex()` binary search utility for time-series lookups in `backtestRunner.ts` and `dnsePublic.ts`. This vastly improves the algorithmic time complexity of lookup routines within the simulation loop.

Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Replaces the O(n) `.filter()` array scanning with an O(log n) `findLastBarIndex()` binary search utility for time-series lookups in `backtestRunner.ts` and `dnsePublic.ts`. This vastly improves the algorithmic time complexity of lookup routines within the simulation loop. Also adds pnpm overrides for vulnerable ws and undici packages to fix the failing audit CI check.

Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant