⚡ Bolt: [replace O(n) filter with O(log n) lookup] - #90
Conversation
Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
💡 What: Added
findLastBarIndexbinary search utility insrc/data/sources/dnsePublic.tsand updatedsrc/agent/backtestRunner.tsto use it instead of.filter()for time-series lookups.🎯 Why: Inside the heavy backtest execution loop,
.filter((b) => b.time <= asOf)performed an O(n) scan over entire historical arrays and allocated temporary structures, creating an unnecessary bottleneck and GC pressure on what should be O(1) or O(log n) operations on sorted data.📊 Impact: Reduces array allocations inside backtest loops and significantly improves loop performance from O(n) per lookup to O(log n) without sacrificing readability.
🔬 Measurement: Verify with
pnpm testandpnpm typecheck. The backtest runner completes faster.PR created automatically by Jules for task 8921108676787207229 started by @toreleon