⚡ Bolt: Optimize sub-interval extraction to O(log n) - #95
Conversation
Replaced full-array O(n) `.filter()` and O(n log n) `.sort()` with O(log n) binary search in `intervalCloses` in `src/agent/backtestRunner.ts`. This reduces the CPU overhead when slicing chronologically sorted time-series market data for backtesting intervals. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Optimized$O(\log n)$ binary search ($O(n)$ $O(n \log n)$ $O(n \log n)$ to $O(\log n)$ , significantly lowering the computational overhead of generating backtest turns across long timelines.
intervalClosesto extract time-series sub-intervals using anfindLastBarIndex) and.slice(), eliminating the prior.filter()and.sort()calls.🎯 Why: In
backtestRunner.ts, extracting sub-intervals from large OHLCV bar arrays is a hot path. The previous implementation iterated over the entire array for every extraction, which scales poorly with large historical datasets, despite the data inherently being sorted by time.📊 Impact: Reduces time complexity of sub-interval extraction from
🔬 Measurement:
pnpm testandpnpm typecheckpass successfully, and edge cases (where interval boundaries are outside array bounds or do not align perfectly with bars) are correctly covered by bounds checking logic.PR created automatically by Jules for task 9599330657436624779 started by @toreleon