⚡ Bolt: Optimize time-series extraction with binary search - #96
Conversation
Replaces O(n) `.filter()` and O(n log n) `.sort()` operations on time-series arrays with O(log n) binary search bounds and `.slice()`. This improves performance for historical backtesting which does these lookups in a loop. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
Array.prototype.filter()and.sort()on chronologically sorted time-series market data arrays with binary search lower/upper bounds (findFirstBarIndex,findLastBarIndex) and.slice().🎯 Why: Backtesting runs in a tight loop and was frequently extracting time ranges using O(n) array filtering and O(n log n) sorting on arrays that are already chronologically sorted.
📊 Impact: Reduces time complexity of bar range lookups in tight loops from O(n) to O(log n), decreasing overall backtest execution time.
🔬 Measurement: Verify by running the backtest simulation over a long historical period, and observe reduction in CPU time for extracting the
vnindexturns and clamping bars ingetStockOhlcv.PR created automatically by Jules for task 4529289871957363913 started by @toreleon