Refactor property fetching to Gradle properties#287
Open
cpaleop wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #285
Summary
The linked issue describes a failure occurring when Gradle Project Isolation feature is enabled.
Project Isolation is promoted to incubating status in Gradle 9.7.0 which allows for early adoption, and some of our repositories only fail with the issue described here.
The issue with my change is that it will probably require changes to your docs. My changes introduce behavioral changes, because properties defined in the root project will no longer be accessible. Only properties set via:
gradle.properties-Pprefix in CLIFix
Followed Gradle's suggestion when it comes to fetching properties, specifically this guide. In addition, this had a nice improvement in Gradle 9.6.0 in regards of configuration cache.