fix(hedge): assert non-zero rotation period on construction#864
Open
Alpy16 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where
Hedge::newandHedge::new_with_mock_latenciesaccept aDuration::ZEROrotation period during configuration. This behavior subsequently causes an unrecoverable integer divide-by-zero panic inRotatingHistogram::maybe_rotateupon the first request invocation.By validating the
periodparameter at the API boundary via an explicit assertion, this change ensures that invalid configurations fail-fast during initialization rather than causing runtime instability.Type of Change
Proposed Changes
assert!(period > Duration::ZERO, ...)toHedge::new.Hedge::new_with_mock_latenciesto protect immediate history pre-population logic.hedgeintegration test suite covering both constructors.Verification Run
Executed the module integration tests locally across the workspace using:
cargo test --package tower --all-featuresAll 7 tests within
tests/hedge/main.rspassed successfully alongside the rest of the workspace and doc-test suite.Closes #862