Skip to content

Use default value cmd.exe for ENV["COMSPEC"]#11

Merged
tpapp merged 1 commit into
tpapp:masterfrom
fonsp:patch-1
Sep 2, 2020
Merged

Use default value cmd.exe for ENV["COMSPEC"]#11
tpapp merged 1 commit into
tpapp:masterfrom
fonsp:patch-1

Conversation

@fonsp

@fonsp fonsp commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@fonsp

fonsp commented Sep 2, 2020

Copy link
Copy Markdown
Contributor Author

This is two changes in one:

  1. The default value for get(ENV, "COMSPEC", "cmd") was not used
  2. Using cmd.exe instead of cmd means that it will work from WSL (which I will submit a 2nd PR for)

EDIT: 1. is also done by #10

@tpapp

tpapp commented Sep 2, 2020

Copy link
Copy Markdown
Owner

Thanks!

@tpapp tpapp merged commit 1017db3 into tpapp:master Sep 2, 2020
@fonsp fonsp deleted the patch-1 branch September 2, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants