Skip to content

Unroll _transform_tuple to fix Enzyme.autodiff on tuples of length ≥ 33 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlperla wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Unroll _transform_tuple to fix Enzyme.autodiff on tuples of length ≥ 33 #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions src/aggregation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,15 +392,25 @@ $(SIGNATURES)

Helper function for transforming tuples. Used internally, to help type inference. Use via
`transfom_tuple`.
"""
_transform_tuple(flag::LogJacFlag, x::AbstractVector, index, ::Tuple{}) =
(), logjac_zero(flag, _ensure_float(eltype(x))), index

function _transform_tuple(flag::LogJacFlag, x::AbstractVector, index, ts)
tfirst = first(ts)
yfirst, ℓfirst, index′ = transform_with(flag, tfirst, x, index)
yrest, ℓrest, index′′ = _transform_tuple(flag, x, index′, Base.tail(ts))
(yfirst, yrest...), ℓfirst + ℓrest, index′′
Implemented as a `@generated` straight-line unroll over the static tuple length.
Equivalent to the natural `Base.tail` recursion, but emits non-recursive code
so that `Enzyme.autodiff` does not hit `AssertionError("conv == 37")` on
tuples of length ≥ 33 (EnzymeAD/Enzyme.jl#3104).
"""
@generated function _transform_tuple(flag::LogJacFlag, x::AbstractVector, index,
ts::Tuple{Vararg{AbstractTransform,N}}) where {N}
N == 0 && return :(((), logjac_zero(flag, _ensure_float(eltype(x))), index))
ys = [Symbol(:y_, i) for i in 1:N]
ℓs = [Symbol(:ℓ_, i) for i in 1:N]
calls = [:(($(ys[i]), $(ℓs[i]), idx) = transform_with(flag, ts[$i], x, idx))
for i in 1:N]
ℓ_sum = foldl((a, b) -> :($a + $b), ℓs)
return quote
idx = index
$(calls...)
(($(ys...),), $ℓ_sum, idx)
end
end

"""
Expand Down