[TPDE] Do not assert completed write in FunctionWriter dtor

In an OOM situation it is not guaranteed that `flush()` is called on the FunctionWriter, before destroying it.

Change-Id: I29e6754e1fc9f4ca655de710e9306d6bf00e9791

Author: marcauberer

tpde/include/tpde/FunctionWriter.hpp

@@ -127,11 +127,6 @@ class FunctionWriterBase {
 protected:
   FunctionWriterBase(const TargetCIEInfo &cie_info) : cie_info(cie_info) {}
 
-  ~FunctionWriterBase() {
-    assert(data_cur == data_reserve_end &&
-           "must flush section writer before destructing");
-  }
-
 public:
   /// Get the SecRef of the current section.
   SecRef get_sec_ref() const { return get_section().get_ref(); }

tpde/src/FunctionWriter.cpp

@@ -29,6 +29,8 @@ void FunctionWriterBase::end_module() {
     *reinterpret_cast<u32 *>(eh_writer.data() + fde_start) += 4;
   }
   eh_writer.flush();
+
+  assert(data_cur == data_reserve_end);
 }
 
 void FunctionWriterBase::begin_func() {