Extrude/transform preview performance and multi-select retention - #226
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a40c836. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Redisplay; disable dynamic highlight while active to avoid ghost wireframes; keep and restore multi-selection on enter, finalize, and Escape; skip AIS select on the finalize LMB release; undo/redo returns to Normal instead of re-entering the free-drag tool.ezy.view.set_selected(...)for Python, Lua, and the remote client.Closes #225
Test plan
ctest -C Releaseview.set_selected(view.get_selected())docs/usage.md/usage-settings.md/scripting.md, CHANGELOGNote
Medium Risk
Touches core viewer input (mode enter, LMB routing, undo mode restore) and transform/extrude preview paths; behavior changes are user-visible but localized to interactive tools rather than persistence or auth.
Overview
Improves sketch-face extrude and Move / Rotate / Scale responsiveness, and fixes selection loss around transform and extrude workflows.
Extrude adds a hybrid drag preview: simple faces still get a shaded
MakePrismsolid; dense faces (when Settings → Sketch → Appearance → Extrude fast preview is on, default edge threshold 24) preview by translating face copies, including both ends when Both sides is on. Finalize always builds the real solid; length dimension handling is reworked for both-sides toggles.Move / Rotate / Scale stop per-frame
Redisplayduring preview—onlySetLocalTransformationplus a viewer redraw—and turn off AIS dynamic highlight while those tools are active to avoid wireframe ghosts on stale selection BVHs. Entering a transform mode snapshots and restores multi-selection viaset_selected_shpsand seeds operands withbegin(); finalize/cancel re-selects all operands and skips AIS press/release on the finalize LMB so release cannot collapse multi-select. Undo/redo maps stored Move/Rotate/Scale back to Normal instead of re-entering free-drag.Scripting:
ezy.view.set_selected(...)(Python, Lua, remoteezycadclient). Settings persistgui.extrude_fast_previewandgui.extrude_fast_preview_edge_threshold.Reviewed by Cursor Bugbot for commit a40c836. Bugbot is set up for automated code reviews on this repo. Configure here.