Drastically simplify changes to verify.go#1
Open
aarongable wants to merge 1 commit into
Open
Conversation
|
|
Author
|
Hmm, signing the CLA doesn't seem like the right move here -- this is a contribution not to a ToB repo, but to a ToB PR against my own repo. I could bypass the ToB PR and make my own PR against my own repo, but that feels rude. Let me know what the right next step is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a whole layer of abstraction from verify.go, making the changes easier to reason about. It also undoes some of the unnecessary comment updates, making the diff easier to review. I think that, with this change incorporated, we will be very likely to accept letsencrypt#8796.