Skip to content

Drastically simplify changes to verify.go#1

Open
aarongable wants to merge 1 commit into
trailofbits:patch/issues-8-9-fresh-account-authfrom
letsencrypt:get-only-account-cache
Open

Drastically simplify changes to verify.go#1
aarongable wants to merge 1 commit into
trailofbits:patch/issues-8-9-fresh-account-authfrom
letsencrypt:get-only-account-cache

Conversation

@aarongable

Copy link
Copy Markdown

This removes a whole layer of abstraction from verify.go, making the changes easier to reason about. It also undoes some of the unnecessary comment updates, making the diff easier to review. I think that, with this change incorporated, we will be very likely to accept letsencrypt#8796.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aarongable

Copy link
Copy Markdown
Author

Hmm, signing the CLA doesn't seem like the right move here -- this is a contribution not to a ToB repo, but to a ToB PR against my own repo. I could bypass the ToB PR and make my own PR against my own repo, but that feels rude. Let me know what the right next step is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants