feat: use effective release date for episodes#147
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an effectiveReleaseDate to the Episode model, providing a more accurate way to determine when an episode is released. It consolidates release date logic into a new releasedAt property and migrates the model to use Instant instead of ZonedDateTime. Additionally, various UI components were updated to leverage these changes, simplifying release status checks and improving date handling across the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the Episode model from ZonedDateTime to Instant and introduces an effectiveReleaseDate field, consolidating release logic into a new releasedAt property and a rememberReleased() Composable helper. The feedback highlights logic inversions in EpisodeSeasonEpisodesList.kt and ShowEpisodesList.kt where 'upcoming' chips are incorrectly shown for released episodes. Additionally, suggestions were made to improve the precision of Instant comparisons in the isReleased check and to simplify the EpisodeHeader logic using the new helper.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the Episode model to use Instant instead of ZonedDateTime and introduces an effectiveReleaseDate field to improve release date handling. It updates various UI components to use releasedAt and the new rememberReleased() helper for consistent release status checks. The review identified two logic inversions in UI components where the upcoming episode chip was incorrectly displayed for released episodes, as well as a suggestion to simplify the isReleased property implementation in the Episode model.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the Episode model to introduce effectiveReleaseDate and a unified releasedAt property, replacing the previous firstAired logic. It updates various UI components to use this new releasedAt property and the rememberReleased() helper method for consistency. The reviewer provided a suggestion to simplify the isReleased property implementation in Episode.kt for better readability and safety.
There was a problem hiding this comment.
Code Review
This pull request refactors the Episode model to use Instant instead of ZonedDateTime and introduces effectiveReleaseDate and releasedAt properties. It also adds a rememberReleased() Composable helper and updates numerous UI components across the mobile and TV modules to use these new fields for release status and date formatting. A review comment suggests simplifying the isReleased getter in Episode.kt to be more idiomatic.
No description provided.