Add timeout parameter to BulkImport.perform() method#132
Merged
Conversation
Co-authored-by: chezou <916653+chezou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Can you create a PR to allow bulk_import_model.perform() to set timeout similar as bulk_import_model.commit()? Just passing timeout option to L.120 should be fine.
Add timeout parameter to BulkImport.perform() method
Aug 9, 2025
chezou
approved these changes
Aug 9, 2025
chezou
pushed a commit
to treasure-data/pytd
that referenced
this pull request
Aug 11, 2025
tung-vu-td
pushed a commit
to treasure-data/pytd
that referenced
this pull request
Aug 14, 2025
* Support td-client perform timeout. Follow up treasure-data/td-client-python#132 * Fix dependent td-client version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
timeoutparameter to theBulkImport.perform()method to allow users to set a timeout for bulk import operations, similar to the existingBulkImport.commit()method.Changes
timeout=Noneparameter toBulkImport.perform()method signaturejob.wait()whenwait=TrueUsage
Backward Compatibility
This change is fully backward compatible. All existing code will continue to work exactly as before, with the timeout defaulting to
None(no timeout) when not specified.The implementation leverages the existing timeout functionality in the
Job.wait()method, ensuring consistent behavior across the codebase.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.