Conversation
chezou
force-pushed
the
py314
branch
3 times, most recently
from
1e540f8 to
7de4b20
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase to require Python 3.10+ as the minimum version, removing support for Python 3.8 and 3.9. The changes leverage Python 3.10's native type union syntax and eliminate the need for backward-compatibility imports.
- Removed
from __future__ import annotationsacross all files - Replaced
typing-extensionsusage with native Python 3.10+ typing features - Updated Python version requirements and CI configurations
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated minimum Python version to 3.10, removed typing-extensions dependency, added Python 3.13-3.14 classifiers |
| .github/workflows/pythontest.yml | Updated CI matrix to test Python 3.10-3.14 instead of 3.8-3.12 |
| test-requirements.txt | Removed mock library, updated pytest to 8.3+ |
| tdclient/types.py | Converted type aliases from string literals to native union syntax |
| tdclient/util.py | Applied union syntax and strict=False parameter to zip() |
| tdclient/*.py (multiple files) | Removed future annotations imports, converted TYPE_CHECKING guards to regular imports, added forward reference quotes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit db56064.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #139