Skip to content

tests: cover ensure_list and nested_contains #11071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eeshsaxena wants to merge 1 commit into from
+30 −0
Closed

tests: cover ensure_list and nested_contains #11071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tests/unit/utils/test_collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

from dvc.utils.collections import (
apply_diff,
ensure_list,
merge_dicts,
nested_contains,
remove_missing_keys,
to_omegaconf,
)
Expand Down Expand Up @@ -139,3 +141,31 @@ def test_remove_missing_keys(changes, expected):
assert removed == expected == params
assert params is removed # references should be preserved
assert is_serializable(params)


@pytest.mark.parametrize(
"item, expected",
[
(None, []),
("foo", ["foo"]),
(["foo", "bar"], ["foo", "bar"]),
(("foo", "bar"), ["foo", "bar"]),
([], []),
],
)
def test_ensure_list(item, expected):
assert ensure_list(item) == expected


@pytest.mark.parametrize(
"dictionary, phrase, expected",
[
({"foo": 1, "bar": 2}, "foo", True),
({"foo": 0}, "foo", False), # falsy value does not count
({"foo": {"bar": {"baz": 1}}}, "baz", True), # nested match
({"foo": 1}, "bar", False), # missing key
({}, "foo", False),
],
)
def test_nested_contains(dictionary, phrase, expected):
assert nested_contains(dictionary, phrase) is expected
Loading