Skip to content

fix logic error in blocksort#138

Merged
folkertdev merged 1 commit into
mainfrom
fix-issue-137
May 15, 2026
Merged

fix logic error in blocksort#138
folkertdev merged 1 commit into
mainfrom
fix-issue-137

Conversation

@folkertdev
Copy link
Copy Markdown
Member

Fixes #137

The analysis in the issue is correct I think, the loop was doing something slightly subtle. I used alive2 to verify that the version in this PR is equivalent, but it is more efficient (based on the assembly and it not looping).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
libbz2-rs-sys/src/blocksort.rs 87.50% 1 Missing ⚠️
Flag Coverage Δ
fuzz-compress_then_decompress 50.68% <0.00%> (-0.05%) ⬇️
fuzz-decompress_chunked 30.20% <0.00%> (-1.39%) ⬇️
test-aarch64-apple-darwin 90.02% <90.90%> (-0.01%) ⬇️
test-aarch64-unknown-linux-gnu 89.87% <90.90%> (+<0.01%) ⬆️
test-i686-unknown-linux-gnu 89.87% <90.90%> (+<0.01%) ⬆️
test-x86_64-apple-darwin 89.87% <90.90%> (+<0.01%) ⬆️
test-x86_64-unknown-linux-gnu 90.02% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test-libbz2-rs-sys/src/lib.rs 95.90% <100.00%> (+0.01%) ⬆️
libbz2-rs-sys/src/blocksort.rs 98.96% <87.50%> (-0.17%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@folkertdev folkertdev merged commit 4a4af7e into main May 15, 2026
25 checks passed
@folkertdev folkertdev deleted the fix-issue-137 branch May 15, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libbzip2-rs: internal error number 1002

2 participants