Return SIGCONT_FG from suspend_pty even when term_raw#1601
Merged
Conversation
Member
|
Clippy is complaining; and given how this PR changes the code I'm inclined to agree with clippy here. :-) |
This fixes the code to match og-sudo and fixes a hang in some circumstances.
squell
added
minor
Collaborator
Author
|
I actually figured I would allow the lint so that it can be written the same way as og-sudo. |
Member
|
I would do it differently, but I don't have a strong opinion and am not willing to sacrifice someone at the altar of Clippy, so fine with me. |
squell
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the code to match og-sudo and fixes a hang in some circumstances.
Fixes #1598