Skip to content

feat(webapp): add emission fan-out metrics to the native realtime feed#4341

Merged
ericallam merged 3 commits into
mainfrom
perf/realtime-serialize-hotpath
Jul 22, 2026
Merged

feat(webapp): add emission fan-out metrics to the native realtime feed#4341
ericallam merged 3 commits into
mainfrom
perf/realtime-serialize-hotpath

Conversation

@ericallam

Copy link
Copy Markdown
Member

Summary

Adds two counters to the native realtime backend so we can see how much duplicate row serialization the change router does per batch. When a run changes it can match several held feeds at once (a run subscription plus one or more tag/list feeds), and today each matching feed serializes that run's wire value independently. These counters quantify that fan-out so we can decide whether a shared serialization step is worth it.

What they measure

  • realtime_native.emission_run_serializations: total wire-value serializations performed across feeds per batch (what the current path does).
  • realtime_native.emission_distinct_serializations: distinct (columns, run) rows those serializations cover (what a serialize-once-per-batch step would do).

Average feeds-per-run is run_serializations / distinct_serializations, and 1 - distinct / run_serializations is the serialization work a shared step could save. Wired through a new optional onEmissionFanout callback on the router. No behavior change.

@changeset-bot

changeset-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2b5e753

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Adds per-batch realtime emission fanout statistics to EnvChangeRouter, including total feed row deliveries and distinct (columnSig, runId) serializations. The native realtime client exposes Prometheus counters and records these values through the router callback. A changelog entry documents the new metrics.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description misses required template sections like Closes #, checklist, testing, changelog, and screenshots. Add the missing template sections, including issue link, checklist items, testing steps, changelog entry, and screenshots or N/A.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: adding emission fan-out metrics to the native realtime feed.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/realtime-serialize-hotpath

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@ericallam
ericallam marked this pull request as ready for review July 22, 2026 16:21

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@ericallam
ericallam merged commit a2d382b into main Jul 22, 2026
35 checks passed
@ericallam
ericallam deleted the perf/realtime-serialize-hotpath branch July 22, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants