fix(sqlalchemy): add literal_processor to TIMESTAMP type#609
Open
q8webmaster wants to merge 1 commit into
Open
fix(sqlalchemy): add literal_processor to TIMESTAMP type#609q8webmaster wants to merge 1 commit into
q8webmaster wants to merge 1 commit into
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Q8Webmaster.
|
SQLAlchemy's DateTime.literal_processor() returns None for Trino's TIMESTAMP type, causing a CompileError when literal_binds=True is used and a datetime value appears in a WHERE clause (e.g. Superset's select_star partition filter). Add a literal_processor to TIMESTAMP that emits a Trino-compatible TIMESTAMP 'YYYY-MM-DD HH:MM:SS[.mmm]' literal.
60ae3e8 to
1f79e64
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TIMESTAMP.literal_processor()is not implemented, causing aCompileErrorwhenliteral_binds=Trueis used with adatetime.datetimevalue in a WHERE clause:Concrete trigger: Apache Superset's
select_star()builds a sample query withWHERE <partition_col> = <latest_partition_value>usingliteral_binds=True. Anytable with a TIMESTAMP partition column hits this on the table metadata endpoint.
Fix
Add
literal_processortoTIMESTAMPemitting a Trino-compatibleTIMESTAMP 'YYYY-MM-DD HH:MM:SS[.mmm]'literal.Tests
Two unit tests added to
tests/unit/sqlalchemy/test_compiler.py:TIMESTAMP '2026-06-17 09:57:43.244'TIMESTAMP '2026-06-17 09:57:43'