Repository navigation
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
…2577) Co-authored-by: Cursor <cursoragent@cursor.com>
Qodex reviewReviewed units u1. The history note now distinguishes session lists from shared links. Effort: ●●●○○ (3/5) · No findings worth raising. The diff reads clean. Scope: the whole pull request (no previous review: the whole change is reviewed). WalkthroughNotes
What Qodex checkedLenses (openqodex review with checked answers, all dimensions)
Scanners
Quality filters
Verification (M1b probes against PR preview)
Cross-review dedup
Output
Reviewer: shown 2 of 2 changed hunks, opened 7 files, 28 tool calls served, 17 model calls, 0 correction rounds, 68.9s. The library does not report tool calls asked apart from those it served, or a step cap. Every dimension is reviewed. Bugs, security, and performance post inline; low-severity style and convention notes are collected in the group above rather than dropped. Mark a finding resolved or flag a false positive in the Qodex Pull Requests view. |
Summary
Documents session sharing (AGE-2577), added in #1122 and #1123, on the Sessions page of trueforge.dev.
Changes
docs/sessions.mdx:session_sharing.granularitycapability.How was this tested?
npx mint broken-linksindocs/: no broken links. This also confirms the MDX parses.docs/sessions.mdx.Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Low Risk
Documentation-only changes to the Sessions MDX; no runtime or API behavior changes.
Overview
Extends the Sessions page to cover read-only session sharing: how creators share from the UI (add people, Restricted vs Everyone within tenant, copy Share URL), what recipients can and cannot do, and when per-user vs tenant-only sharing applies (user directory on TrueFoundry; local/OIDC limits).
The owner-scoped history note now says shared sessions open from their share link rather than appearing in someone else’s list.
Adds Share from the SDK with TypeScript and Python examples for grant/revoke via
updateGrants, links to list/update grants and list users APIs, and documents that only the creator can manage grants and thatsession_sharing.granularityreflects subject vs tenant sharing availability.Reviewed by Cursor Bugbot for commit 578cdf2. Bugbot is set up for automated code reviews on this repo. Configure here.