fix(tagxl): gate port 151 reset reason feature#194
Conversation
Only advertise reset reason when the decoded reset cause is meaningful, preventing settings payloads with null or unknown causes from downstream reset events.
|
@coderabbitai review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTAG XL v1 port 151 now includes ChangesPort 151 ResetReason Dynamic Feature Filtering
CI Lint Action Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Action performedReview finished.
|
|
@niko-kriznik-globtim please fix CI |
Use a newer golangci-lint patch that passes locally and avoids the CI action failure seen with the older v2.1 pin.
5e4f244
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Summary
0x4adecodes to a meaningful reset cause.Test plan
go test ./pkg/decoder/tagxl/v1/... -run 'Port151|Reset'go test ./...Refs truvami/bridge#234
Summary by CodeRabbit