fix(deps): patch engine.io (#93) & body-parser (#92) Dependabot alerts#3464
Merged
Conversation
- engine.io: add bun override to ^6.6.7. The vulnerable 6.5.5 (Engine.IO polling connection-exhaustion DoS, <6.6.7) was pulled transitively via @trigger.dev/core -> socket.io@4.7.4. Override collapses it to 6.6.9 (the version top-level socket.io@4.8.3 already uses); bun.lock now has a single engine.io@6.6.9. Not a reachable DoS for us (we run no engine.io server; trigger.dev uses it client-side) but removes the alert. - body-parser: bump the transitive dep in apps/mcp-server (runtime, via express@5.2.1) 2.2.2 -> 2.3.0 (patched; DoS via invalid limit silently disabling size enforcement). Lockfile-only; express's ^2.2.1 range permits 2.3.0, so it stays transitive and survives SDK regeneration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 3/5
- In
package.json, the global override forcingengine.ioto 6.6.9 can putsocket.io@4.7.4outside Trigger.dev’s expected~6.5.2range, which risks task/realtime connection failures after merge. Revert or narrow the override to a Trigger.dev-compatibleengine.ioversion and verify a Trigger.dev connection smoke test before merging.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:109">
P2: Trigger.dev task/realtime connections can break if socket.io 4.7.4 relies on engine.io 6.5-specific behavior, because this global override forces 6.6.9 outside its declared `~6.5.2` range. A Trigger.dev connection smoke test or an upgrade to a Trigger.dev/socket.io version declaring the patched range would make this compatibility change safe rather than relying only on the top-level socket.io 4.8.3 consumer.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| "@vitest/ui": "^3.2.7", | ||
| "form-data": "^4.0.6", | ||
| "ws": "^8.21.0", | ||
| "engine.io": "^6.6.7", |
Contributor
There was a problem hiding this comment.
P2: Trigger.dev task/realtime connections can break if socket.io 4.7.4 relies on engine.io 6.5-specific behavior, because this global override forces 6.6.9 outside its declared ~6.5.2 range. A Trigger.dev connection smoke test or an upgrade to a Trigger.dev/socket.io version declaring the patched range would make this compatibility change safe rather than relying only on the top-level socket.io 4.8.3 consumer.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 109:
<comment>Trigger.dev task/realtime connections can break if socket.io 4.7.4 relies on engine.io 6.5-specific behavior, because this global override forces 6.6.9 outside its declared `~6.5.2` range. A Trigger.dev connection smoke test or an upgrade to a Trigger.dev/socket.io version declaring the patched range would make this compatibility change safe rather than relying only on the top-level socket.io 4.8.3 consumer.</comment>
<file context>
@@ -106,6 +106,7 @@
"@vitest/ui": "^3.2.7",
"form-data": "^4.0.6",
"ws": "^8.21.0",
+ "engine.io": "^6.6.7",
"semver": "^7.8.5",
"hono": "^4.12.25",
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the last 2 open Dependabot alerts. Both are runtime scope (not dev-only), so fixed — not dismissed. Branched off
mainafter #3462 (adm-zip) merged;bun.lockregenerated cleanly.#93 — engine.io (High): Engine.IO polling connection-exhaustion DoS
engine.io@6.5.5(<6.6.7) was pulled transitively via@trigger.dev/core → socket.io@4.7.4.override:"engine.io": "^6.6.7".bun.locknow resolves a singleengine.io@6.6.9— the same version the top-levelsocket.io@4.8.3already uses (so wire/protocol compat is proven in-repo). Diff is scoped to engine.io + its own sub-deps only.socket.ioserver usage); trigger.dev uses it client-side, so this wasn't a reachable DoS — but the override removes the version entirely.#92 — body-parser (Low): DoS via invalid
limitsilently disabling size enforcementdev=false) of the published@trycompai/mcp-server, pulled byexpress@5.2.1. Resolved 2.2.2 (<2.3.0).express's^2.2.1range already permits 2.3.0, so it stays transitive (package.json untouched) and survives Speakeasy SDK regeneration.Validation
bun.lockchange is scoped to the engine.io subtree; mcp-serverpackage.jsonunchanged.Summary by cubic
Fixes two runtime security alerts by upgrading
engine.ioandbody-parser. No app code changes; resolves DoS risks flagged by Dependabot.engine.io: Add override to^6.6.7, locking to6.6.9across the repo (transitive via@trigger.dev/core→socket.io). Matches the version used by top-levelsocket.io@4.8.3; we don’t run anengine.ioserver but this removes the vulnerable version.body-parser: Bump transitive dep inapps/mcp-serverfrom2.2.2to2.3.0via lockfile (pulled byexpress@5.2.1) to fix invalid limit DoS.Written for commit 31aca30. Summary will update on new commits.