🔧 Bugfix: fix inject binary packaging issue in gradle script#776
Conversation
The `cargoBuild` task in `module/build.gradle.kts` was incorrectly copying the compiled `daemon` binary into a directory named `inject` (resulting in `lib/<abi>/inject/daemon`) instead of renaming the file to `inject` directly inside the ABI folder.
This commit updates the gradle `copy` block to target the ABI directory via `into()` and uses `rename { "inject" }` to ensure the binary is correctly placed and named in the resulting zip, resolving installation failures complaining about missing `inject` executable.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The
cargoBuildtask inmodule/build.gradle.ktswas incorrectly copying the compileddaemonbinary into a directory namedinject(resulting inlib/<abi>/inject/daemon) instead of renaming the file toinjectdirectly inside the ABI folder.This commit updates the gradle
copyblock to target the ABI directory viainto()and usesrename { "inject" }to ensure the binary is correctly placed and named in the resulting zip, resolving installation failures complaining about missinginjectexecutable.PR created automatically by Jules for task 9650432353158682687 started by @tryigit