Only use semverCompare with valid version strings#267
Merged
Conversation
Apply the same regexFind fix to the remaining semverCompare call on .Values.image.tag in deployment_jobs.yaml, so tags with leading-zero prerelease segments (e.g. 3.284.10-0360315) are handled correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jjlgao
force-pushed
the
fix_semverCompare_issue
branch
from
5afdd14 to
eb48a41
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jjlgao
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle image tags where the pre-release part of the semver version string contains a leading zero, e.g.
3.284.10-0360315.Fix for errors like this: