Fix project context resolution for file-based commands#3174
Draft
techmannih wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
File-based commands were resolving runtime project context from
process.cwd()instead of the target file path.That meant
tsci exportandtsci simulate analogcould load the wrongtscircuit.config.*and resolve the wrong user-land dependencies when they were run from outside the target project directory.Before
exportloaded runtime config from the shell working directorysimulate analogloaded runtime config from the shell working directoryAfter
tscircuit.config.ts,tscircuit.config.js, ortscircuit.config.jsonstarting from the target file directoryexportandsimulate analognow behave consistently when invoked with absolute or nested file paths from outside the target project directoryWhat Changed
exportto resolve runtime config from the target file pathsimulate analogto use the same project resolution behavior@tscircuit/ti-parts-enginetopackage.jsonbun.lockfor the new dependencyValidation
bun test tests/cli/runtime-project-config-command-flows.test.tsbun test tests/lib/project-config.test.tsbun test tests/cli/export/export-circuit-json.test.ts tests/cli/export/export-kicad-library.test.ts tests/cli/simulate/simulate.test.ts