fix: keep disk proxy reads inside proxy root#123
Open
sagarmaurya64-ai wants to merge 1 commit into
Open
Conversation
Author
|
Thanks for reviewing. I noticed the download endpoint was already present, so I audited the disk proxy handling and added a small containment fix with a regression test. |
Author
|
Hi maintainers, thanks for taking a look. I noticed the original download endpoint work was already implemented, so I audited the related disk proxy code and found a path containment issue. This PR adds a small security fix and regression test to prevent disk proxy reads from escaping the configured proxy root. Would this qualify for a bounty/reward, or should I link it to a separate issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a disk proxy path containment issue.
The disk proxy previously joined the configured proxy root with the requested relative path without verifying the resolved result stayed inside the proxy root. This patch resolves both paths, checks the relative path remains within the root, and returns the existing 404 response for out-of-root requests.
Verification: