Add deterministic decoupling capacitor layout#110
Open
justusaugust wants to merge 1 commit into
Open
Conversation
|
@justusaugust is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partitionType === "decoupling_caps"path that bypasses genericPackSolver2and emits a deterministic centered row/stackcircuit-to-svg@0.0.345directly so the existing full test suite can loadconvertCircuitJsonToSchematicSimulationSvg/claim #15
Demo / visual proof
https://github.com/justusaugust/matchpack/releases/download/matchpack-15-demo-2026-05-25/matchpack-15-demo.mp4
The video shows the same pin-envelope regression covered by the new visual snapshot test: current
mainstill routes cap-only partitions through the generic packer, while this patch solves the partition in one step as a centered ordered row with measured centersC1=-1.55,C2=0.00,C10=1.55.Verification
bun test tests/PackInnerPartitionsSolver/decoupling-cap-layout.test.ts tests/ChipPartitionsSolver.test.ts— 7 pass, 1 snapshotbun test— 21 pass, 1 skip, 0 failbunx tsc --noEmitbun run format:checkbun run buildgit diff --checktest,format-check, andtype-checkpass onb828c7dVercel is blocked by the usual fork authorization gate.