add oval hole interface and corresponding tests#689
Merged
Conversation
7d8853d to
306c583
Compare
techmannih
reviewed
Jun 4, 2026
Member
techmannih
left a comment
There was a problem hiding this comment.
Any issue? any motivation for these props. please always try to link the issue which you working on
Contributor
Author
|
@techmannih already supported in 3d viewer and circuit-json |
Member
|
@rushabhcodes we never match with circuit-json to props |
Contributor
Author
|
3d-viewer |
Member
|
Please always try to discuss the proposed fix in the contributor channel before opening a PR |
seveibar
approved these changes
Jun 4, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a new "oval" hole type to the PCB layout components. The main changes involve defining the new
OvalHolePropsinterface, updating type unions and validation schemas, and adding tests to ensure correct behavior.already supported in 3d viewer and circuit-json
Support for Oval Hole Type:
OvalHolePropsinterface, including properties such asname,shape,width,height,solderMaskMargin, andcoveredWithSolderMasktohole.ts.HolePropsunion type to includeOvalHoleProps, allowing oval holes to be used wherever holes are accepted.ovalHolePropsfor oval holes and included it in the overallholePropsunion schema. [1] [2]Testing:
widthandheight, and that the properties are parsed and typed correctly.