Preserve obstacle connectivity in mesh nodes#138
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0hmX
marked this pull request as ready for review
July 20, 2026 03:40
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectedTonames directly to_connectedToconnectedToByZ/_connectedToByZRoot cause
finalizeRectsgrouped obstacle output using only XY geometry. Distinct SRJ obstacles could therefore be merged when they shared bounds despite belonging to different layers or nets.Impact
Free-space generation still uses the per-layer obstacle indexes. Final obstacle nodes now come directly from SRJ, preserving each obstacle's layer and connectivity identity without extra per-layer metadata.
Validation
bun test tests/obstacle-connectivity.test.tsbun run buildbun run format:check