fix(scanner): add missing PipelineMode RPCs to methodToID map#164
Closed
tstapler wants to merge 1 commit into
Closed
fix(scanner): add missing PipelineMode RPCs to methodToID map#164tstapler wants to merge 1 commit into
tstapler wants to merge 1 commit into
Conversation
The CreatePipelineMode/UpdatePipelineMode/DeletePipelineMode/GetPipelineMode/ ListPipelineModes RPCs were merged (edcf2f2 etc.) without corresponding entries in tools/scanner/backend/proto_scanner.go's methodToID map, causing TestMethodToIDCompleteness to fail on main and block merge-blocking CI for unrelated PRs. Also finishes the tail end of the same PipelineMode work: per-feature registry files for the 5 RPCs and e2e coverage (settings CRUD page, per-item mode selector, "what ran" snapshot surface) per docs/tasks/backlog-feature-improvement.md's prior audit note. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ Registry ValidationTest Coverage: 8/172 features have
|
Contributor
Go Benchmarks (Tier 1) |
Contributor
Frontend Terminal Throughput |
Contributor
E2E RPC Latency |
Contributor
🎬 E2E Feature Demos2 shard(s) recorded feature flows for this PR. recordings shard 1 Demo preview opens directly in browser (single-file HTML). Raw WebM recordings in ZIP. Expires after 30 days. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestMethodToIDCompletenesshas been failing onmainfor several runs, blocking the merge-blockingTestjob for unrelated open PRs (feat(backlog): opt-in auto-create-PR policy for Review Queue #159-fix(backlog): sync PR branch with main before respawning a fix session #163).PipelineModeCRUD RPCs (CreatePipelineMode,UpdatePipelineMode,DeletePipelineMode,GetPipelineMode,ListPipelineModes) were merged tomainwithout corresponding entries intools/scanner/backend/proto_scanner.go'smethodToIDmap.docs/tasks/backlog-feature-improvement.md's prior audit note: per-feature registry files and e2e coverage.Changes
tools/scanner/backend/proto_scanner.go— added the 5 missingmethodToIDentries (backlog:create-pipeline-mode,backlog:update-pipeline-mode,backlog:delete-pipeline-mode,backlog:get-pipeline-mode,backlog:list-pipeline-modes).docs/registry/features/backend/backlog/for the PipelineMode RPCs.tests/e2e/backlog-pipeline-mode.spec.ts(3 scenarios: create mode via settings page, select mode on a backlog item + persistence, "what ran" snapshot surface) +tests/e2e/pages/PipelineModesSettingsPage.tspage helper + a small addition totests/e2e/pages/BacklogPage.tsfor the mode selector locator.Impact
Testing
go test ./tools/scanner/...(all 12 tests, includingTestMethodToIDCompleteness) — passingmake registry-generate/make registry-diff— 0% divergence, no unexpected changes to tracked filesnpx tsc --noEmiton new/changed e2e files — clean./stapler-squad --tmux-keep-server); spec follows established conventions (data-testid/ARIA locators, no waitForTimeout,@featureheader) and references real, existing frontend/backend code (verified by inspection)Reviewer Notes
data-testid, page route, and backend field actually exists in the codebase.go.work/go.work.sumfound untracked in a sibling checkout were intentionally excluded — they're a local Go workspace convenience file pointing at absolute paths on that machine, not project config.