[CGFCOLLECTOR] Adding Fortran call graph collector#115
Open
gomfol12 wants to merge 168 commits intotudasc:develfrom
Open
[CGFCOLLECTOR] Adding Fortran call graph collector#115gomfol12 wants to merge 168 commits intotudasc:develfrom
gomfol12 wants to merge 168 commits intotudasc:develfrom
Conversation
pearzt
requested changes
Feb 6, 2026
Member
pearzt
left a comment
pearzt
left a comment
There was a problem hiding this comment.
Thanks a lot for all the work, the structure looks really good. I have some initial comments, but I will try to do a more in-depth review soon.
jplehr
reviewed
Feb 13, 2026
Member
jplehr
left a comment
jplehr
left a comment
There was a problem hiding this comment.
Thank you for working on this.
I did an initial brief pass, please go through the comments and address them.
One more question: Does this PR as-is already run CI pipelines? If not, please add it to the CI pipelines as appropriate.
Member
|
Please rebase this onto the most current |
gomfol12
force-pushed
the
fortran_collector
branch
from
01f3d3f to
ed5d7ff
Compare
pearzt
requested changes
Feb 17, 2026
gomfol12
force-pushed
the
fortran_collector
branch
from
d0aea8b to
4f762f9
Compare
gomfol12
changed the title
gomfol12
force-pushed
the
fortran_collector
branch
from
c60137a to
6336aee
Compare
TimHeldmann
requested changes
Mar 13, 2026
cgfcollector/src/FortranUtil.cpp
Outdated
| return typeSymbol; | ||
| } | ||
|
|
||
| std::vector<const Type*> findTypeWithDerivedTypes(const std::vector<Type>& types, const Symbol* symbol) { |
Member
There was a problem hiding this comment.
Why is this a vector?
This could be a map of "Type -> List[Implementations]"
gomfol12
force-pushed
the
fortran_collector
branch
from
6336aee to
cd87076
Compare
… for debugging graph edges
gomfol12
force-pushed
the
fortran_collector
branch
from
0edae42 to
59ac2ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a call graph collector for Fortran. The collector is implemented as a flang plugin and generates a call graph from source-level. See the tests for a list of language features this plugin covers.
This pull request is quite large, but it is not really possible splitting it in multiply requests without pushing broken code. The tests could be separate into a different pull request, but they are tightly coupled with the collector and would fail without it, so I think keeping it in one pull request makes sense.
What this adds:
cgfcollectorthat includes flang plugin, tests, tools, etc.cgfcollector_wrapper.shandcgfcollector_comp_wrapper.shthat simplify running the plugin.How to run: see
cgfcollector/README.mdThe commit history is a mess, and I don't know how strongly you value a clean git history and if I should clean this up.