Repository navigation
fix(settings): keep native pages visible and private - #94
Merged
turinglambdaai merged 2 commits intoOct 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the three macOS settings regressions reported from the packaged app, while keeping the shared settings contract consistent across all native hosts.
TabViewwith an always-visible native sidebar, so General, Features, AI, Commands, and Sync & Updates never disappear behind the upper-right overflow arrowBoolRPC result instead of leaking a Racketsettings-set!contract violationsettings-listIsolation / overlap
7489abd119a18b77f0cc5036316efe85ab387a92a92877c02b6453b1826bfd061d7bbe70647ce5faOwned files
app/backend.rkttests/backend-wire-test.rktmacos-host/Sources/RivetHost/SettingsView.swiftmacos-host/Sources/RivetHost/RivetHostApp.swiftscripts/e2e/macos-ax.swiftwindows/SettingsWindow.xamlwindows/SettingsWindow.xaml.cpplinux/src/main.cppCHANGELOG.mdVerification
raco test tests/settings-test.rkt tests/backend-wire-test.rkt— passraco test tests/— 133 tests passraco rivet schema check rivet-schema.json --json— compatible, no breaking changesraco rivet acceptance --jsonon this Windows machine:lib.exe) are not installed; not claimed as passRollback
Revert commit
22540b8to restore the prior settings surfaces and wire behavior. No stored settings migration is introduced.