Skip to content

fix(settings): keep native pages visible and private - #94

Merged
turinglambdaai merged 2 commits into
mainfrom
fix/macos-settings-navigation-hotkey-20261025
Oct 25, 2026
Merged

turinglambdaai merged 2 commits into
mainfrom
fix/macos-settings-navigation-hotkey-20261025

Conversation

@turinglambdaai

Copy link
Copy Markdown
Owner

Summary

Fix the three macOS settings regressions reported from the packaged app, while keeping the shared settings contract consistent across all native hosts.

  • replace the adaptive macOS TabView with an always-visible native sidebar, so General, Features, AI, Commands, and Sync & Updates never disappear behind the upper-right overflow arrow
  • replace the macOS free-text global shortcut field with a native recorder that emits only canonical hotkey specs
  • treat rejected settings input as the existing Bool RPC result instead of leaking a Racket settings-set! contract violation
  • remove updater transport URL controls from macOS, Windows, and Linux settings; filter update URL/check timestamp/rollout bucket from public settings-list
  • extend packaged macOS Accessibility acceptance to open Settings with Command-comma, verify all five destinations, select Sync & Updates directly, verify the recorder, and prove updater internals are absent

Isolation / overlap

  • Base SHA: 7489abd119a18b77f0cc5036316efe85ab387a92
  • Rivet pin: a92877c02b6453b1826bfd061d7bbe70647ce5fa
  • Open PRs were checked immediately before the slice and again before commit; none overlapped.
  • This follows merged AI-session PR refactor(ai): extract session lifecycle service #93 as a separate bug-fix slice.

Owned files

  • app/backend.rkt
  • tests/backend-wire-test.rkt
  • macos-host/Sources/RivetHost/SettingsView.swift
  • macos-host/Sources/RivetHost/RivetHostApp.swift
  • scripts/e2e/macos-ax.swift
  • windows/SettingsWindow.xaml
  • windows/SettingsWindow.xaml.cpp
  • linux/src/main.cpp
  • CHANGELOG.md

Verification

  • raco test tests/settings-test.rkt tests/backend-wire-test.rkt — pass
  • raco test tests/ — 133 tests pass
  • raco rivet schema check rivet-schema.json --json — compatible, no breaking changes
  • raco rivet acceptance --json on this Windows machine:
    • core contract — pass
    • embedded RVT1 wire — pass
    • native build/package/UI — unavailable because Visual Studio C++ Build Tools (lib.exe) are not installed; not claimed as pass
  • official CI/Product Acceptance must supply the three-platform native build/package/UI evidence, including the new packaged macOS settings interaction

Rollback

Revert commit 22540b8 to restore the prior settings surfaces and wire behavior. No stored settings migration is introduced.

@turinglambdaai
turinglambdaai merged commit 68334c4 into main Oct 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant