Repository navigation
release: fix "deb" applied as a procedure with non-empty linux-formats (#320) - #321
Merged
Merged
Conversation
…loops verify-linux-native-installers! named its for-loop variable `format`, so the deb branch's (format "Package: ~a" …) applied the loop value — the string "deb" — as a procedure; every production release with a non-empty linux-formats list died after packaging (rivet #320, caught by the previous commit's regression test on CI). Rename the loop variable to fmt here, and in create-linux-installer! and the release summary where the same shadowing was latent.
Owner
Author
|
Red confirmed on CI ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320.
First commit is deliberately red (test-only): it adds the regression test — a project with
linux-formats '("deb")goes through productioncreate-installer!andverify-package!— and should fail on ubuntu withapplication: not a procedure; given: "deb". The second commit applies the fix and turns it green.Root cause
verify-linux-native-installers!(rivet-cli/verify.rkt) named itsforloop variableformat, shadowing the Racket builtin; the deb branch then calls(format "Package: ~a" …), which applies the loop value — the string "deb" — as a procedure. Every project shipping a non-emptylinux-formatslist crashed at production verification, after all installers were built. The same shadowing pattern exists (latently, no builtin call in scope) increate-linux-installer!and the release summary; both are renamed too.