Repository navigation
fix(windows): execute scaffold icon helper instead of commenting it out (#333) - #344
Merged
Merged
Conversation
github-actions
Bot
deleted the
fix/windows-scaffold-icon-newline-20261028
branch
October 29, 2026 00:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression fixed
Rivet's generated WinUI
MainWindow.xaml.cpphad two literal\\nsequences in a C++//comment. The intendedrivet::system::ApplyAppIcon(*this)call was therefore swallowed by the comment; new Windows hosts did not apply the embedded product icon to their main window.rivet/tests/windows-scaffold-icon-contract.rktto catch this exact regression on every CI platform.ApplyAppIcon, secondary-window icon probe, native UI two-window assertions, and MSI-installed icon acceptance already onmain, rather than duplicating those mechanisms.Closes #333 only if the Windows native UI and installed-MSI acceptance gates pass.
Validation
raco test rivet/tests/, Windows native UI, packaged MSI icon assertion, cross-platform CI (pending; no local Racket compiler available).Maintenance provenance
Base
main:441ed1fffdcfc2fa5c1dd8b4369dfa2e04bda445.Read repository
AGENTS.md(c86390b),docs/desktop-closeout-mobile-plan.md(5321e79), family PRODUCT-STANDARD and DOCUMENTATION-LANGUAGES (2026-10-23 revisions), and PORTFOLIO (2026-10-v2). No generated files, release tags, or signing bypasses changed.