Alter Search behavior to update Summary View when project and date inputs change.#34
Open
aholmes wants to merge 1 commit intotwentyTwo:mainfrom
Open
Conversation
This change causes the Summary view to update when: * The Project dropdown changes * The start date changes * The end date changes This allows users to change the summary view without the extra Search button click. This change also alters how the related HTML elements are discovered in the DOM. Each element is queried before event execution, which means they do not need to be queried every time the Search events fire.
aholmes
force-pushed
the
aholmes-automatic-search-on-dropdown-change
branch
from
6809fc0 to
27702d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change causes the Summary view to update when:
This allows users to change the summary view without the extra Search button click.
This change also alters how the related HTML elements are discovered in the DOM. Each element is queried before event execution, which means they do not need to be queried every time the Search events fire.
This PR does not update all DOM queries to only query once. Only the date/project inputs (the ones related to this PR) have been updated.