Skip to content

chore: added fix for snake case nested attributes and import keywork …#779

Merged
kridai merged 1 commit intomainfrom
python-gen-fix
Mar 24, 2026
Merged

chore: added fix for snake case nested attributes and import keywork …#779
kridai merged 1 commit intomainfrom
python-gen-fix

Conversation

@kridai
Copy link
Copy Markdown
Contributor

@kridai kridai commented Mar 24, 2026

Added fix for snake case nested attributes and import keywork error
added the test generation for memory/v1 here to preview twilio/twilio-python#917

snake case
https://github.com/twilio/twilio-python/pull/917/changes#diff-777836e65412325fc37488cd2666c3c5a395f055d5dddee403544a8386dfebf7R48

import keyword generation : https://github.com/twilio/twilio-python/pull/917/changes#diff-116f38979d5ea6f70e7b59044645b2666073bb9259c94a51492bff8ca69f5574

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language according to the code change:
    • Generate twilio-java from our OpenAPI specification using the scripts/build_twilio_library.py using python scripts/build_twilio_library.py path/to/twilio-oai/spec/yaml path/to/twilio-java -l java and inspect the diff
    • Run make test in twilio-java
    • Create a pull request in twilio-java
    • Provide a link below to the pull request, this ensures that the generated code has been verified
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@kridai kridai added this pull request to the merge queue Mar 24, 2026
@kridai kridai removed this pull request from the merge queue due to a manual request Mar 24, 2026
@kridai kridai merged commit 38ccb0b into main Mar 24, 2026
17 checks passed
@kridai kridai deleted the python-gen-fix branch March 24, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants