Add design token foundation#890
Draft
jpurnell wants to merge 1 commit into
Draft
Conversation
Introduces the design token system for Ignite: - DesignToken<Value> generic type with CSS custom property generation - TokenCategory enum (color, spacing, typography, shadow, radius, breakpoint) - TokenValue protocol with concrete types: ColorValue (with hex parsing), SpacingValue (with scale helper), TypographyValue, ShadowValue, RadiusValue, BreakpointValue - AnyDesignToken type erasure for heterogeneous collections - CSSGenerator for compiling tokens to :root custom properties with dark mode media query support Purely additive. DesignSystem protocol and component migration are planned as follow-ups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DesignToken<Value>type with CSS custom property generation (--ig-{category}-{name})TokenCategoryenum andTokenValueprotocolColorValue(with hex parsing),SpacingValue(with scale helper),TypographyValue,ShadowValue,RadiusValue,BreakpointValueAnyDesignTokentype erasure for heterogeneous collectionsCSSGeneratorfor compiling tokens to:rootCSS custom properties with dark mode media query supportDesign
Purely additive — new
Sources/Ignite/DesignSystem/directory. These are the atomic building blocks for a futureDesignSystemprotocol that could replace Bootstrap dependency. The token types are independent of any existing framework code.Test plan
swift buildclean with no warnings